Port Profile Followers/Follows to RQ #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+40
to
+42
| if (!profile.viewer?.following) { | ||
| return | ||
| } |
There was a problem hiding this comment.
There's a split second where profile.viewer.following can be set to pending, and this fn should return early in that case too. Rn we're reusing this prop that's typically either undefined | URI, so that we know a follow request is in-flight.
There was a problem hiding this comment.
So, this is based on the pattern in ProfileHeader so I'd rather align with that. If it's wrong we should fix it in both places — and probably many more places because ProfileHeader uses a similar pattern for a bunch of other handlers. So I'd keep it out of scope of this PR.
gaearon
force-pushed
the
profile-followers-rq
branch
from
03ec8fb to
fb8046c
Compare
gaearon
force-pushed
the
profile-followers-rq
branch
from
fb8046c to
c487e72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProfileFollowersProfileFollowsFollowButtonuseFollowProfileSuggestedFollow